RFR: JDK-8291509 Minor cleanup could be done in sun.security

Sean Mullan mullan at openjdk.org
Fri Aug 26 10:53:13 UTC 2022


On Thu, 25 Aug 2022 18:45:10 GMT, Mark Powers <mpowers at openjdk.org> wrote:

>> src/java.base/share/classes/sun/security/jca/Providers.java line 212:
>> 
>>> 210: 
>>> 211:     // Change the thread local provider list. Use only if the current thread
>>> 212:     // is already using a thread local list, and you want to change it in place.
>> 
>> Hmm, I'm not sure this is more grammatically correct.
>
> I could go either way. The sentence is not that long (it's not a German sentence).  IJ is only a recommendation.

I'm not a grammar expert, but I think using a comma before and is not necessary here and possibly incorrect. See https://www.grammarly.com/blog/comma-before-and/. This seem like a "dependent clause" case.

-------------

PR: https://git.openjdk.org/jdk/pull/9972



More information about the security-dev mailing list