RFR: JDK-8291509 Minor cleanup could be done in sun.security [v3]

Weijun Wang weijun at openjdk.org
Tue Aug 30 21:42:15 UTC 2022


On Tue, 30 Aug 2022 21:25:25 GMT, Mark Powers <mpowers at openjdk.org> wrote:

>> src/java.base/share/classes/sun/security/jca/ProviderList.java line 672:
>> 
>>> 670:             "SHA3-384", "SHA3-512" };
>>> 671:     private static final String[] HmacSHA3Group = { "HmacSHA3-224",
>>> 672:             "HmacSHA3-256", "HmacSHA3-384", "HmacSHA3-512"};
>> 
>> Shall I change these `static final` fields to UPPERCASE?
>
> Why?

http://cr.openjdk.java.net/~alundblad/styleguide/index-v6.html#toc-constants

-------------

PR: https://git.openjdk.org/jdk/pull/9972



More information about the security-dev mailing list