RFR: 8297379: Enable the ByteBuffer path of Poly1305 optimizations [v3]
    Volodymyr Paprotski 
    duke at openjdk.org
       
    Thu Dec  1 18:48:19 UTC 2022
    
    
  
On Tue, 29 Nov 2022 01:16:28 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:
>> Volodymyr Paprotski has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove comment
>
> src/java.base/share/classes/com/sun/crypto/provider/Poly1305.java line 260:
> 
>> 258:         if (buf.hasArray()) {
>> 259:             byte[] input = buf.array();
>> 260:             int offset = buf.arrayOffset();
> 
> arrayOffset returns the offset of the first element of the backing buffer. Need to also take into account the position() of the buffer here. We should also add test case for this.
Thanks for catching this!! Fixed the mainline to handle position(). I have now reworked the test case quite a bit.
-------------
PR: https://git.openjdk.org/jdk/pull/11338
    
    
More information about the security-dev
mailing list