RFR: 8298108: Add a regression test for JDK-8297684 [v5]

Sean Mullan mullan at openjdk.org
Tue Dec 6 15:12:55 UTC 2022


On Tue, 6 Dec 2022 11:13:29 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Please review this test addition as it would have helped discover a regression when https://bugs.openjdk.org/browse/JDK-8269039 got introduced and subsequently backported. What's more, it might help discover similar issues going forward. Thoughts?
>> 
>> Testing: Manually produced a build without [JDK-8269039](https://bugs.openjdk.org/browse/JDK-8269039). Test fails without the fix, passes after.
>
> Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adjust test setup

test/jdk/java/security/SignedJar/spi-calendar-provider/provider/baz/CalendarDataProviderImpl.java line 2:

> 1: /*
> 2:  * Copyright (c) 2012, 2022, Oracle and/or its affiliates. All rights reserved.

Did you copy this code from somewhere else? In any case, the impl seems trivial so I don't think it needs to have the Oracle copyright. Otherwise, you should probably use your own company here, and just put 2022 as the date.

-------------

PR: https://git.openjdk.org/jdk/pull/11515



More information about the security-dev mailing list