RFR: 8281236: (D)TLS key exchange named groups [v4]

Sean Mullan mullan at openjdk.org
Tue Dec 6 17:02:14 UTC 2022


On Tue, 6 Dec 2022 07:58:02 GMT, Xue-Lei Andrew Fan <xuelei at openjdk.org> wrote:

>> This update is to support key exchange named groups customization for individual (D)TLS connection. Please review the CSR as well:
>> CSR: https://bugs.openjdk.org/browse/JDK-8291950
>> RFE: https://bugs.openjdk.org/browse/JDK-8281236
>> Release-note: https://bugs.openjdk.org/browse/JDK-8291975
>> 
>> This is an effort similar to [JDK-8280494: "(D)TLS signature schemes"](https://bugs.openjdk.org/browse/JDK-8280494)
>
> Xue-Lei Andrew Fan has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
> 
>  - check duplicate
>  - Merge
>  - Merge
>  - Merge
>  - add test cases
>  - 8281236: (D)TLS key exchange algorithms

test/jdk/javax/net/ssl/SSLParameters/NamedGroupsSpec.java line 34:

> 32: public class NamedGroupsSpec {
> 33:     public static void main(String[] args) throws Exception {
> 34:         runTest(new String[] {

How about adding a test for a `null` array?

test/jdk/javax/net/ssl/SSLParameters/NamedGroupsSpec.java line 68:

> 66:         SSLParameters sslParams = new SSLParameters();
> 67:         try {
> 68:             sslParams.setNamedGroups(namedGroups);

You should also test that `getNamedGroups` returns the same elements.

-------------

PR: https://git.openjdk.org/jdk/pull/9776



More information about the security-dev mailing list