RFR: 8297798: Timeout with DTLSOverDatagram test template

Rajan Halade rhalade at openjdk.org
Thu Dec 8 19:25:32 UTC 2022


On Wed, 7 Dec 2022 13:04:28 GMT, Matthew Donovan <duke at openjdk.org> wrote:

> This fix is intended to address various time-out errors in tests that use DTLSOverDatagram as a test template. Based on test output from those bugs (JDK-8202059, JDK-8249562, JDK-8280185, JDK-8280186, JDK-8269887, JDK-8268899), this fix:
> 
> * refactors the class to only create one additional thread
> * adds a CountdownLatch so if the server thread doesn't start for some reason, it is reported quickly
> * cleans up code to remove a loop condition that never fired: tests always time-out before too many loop iterations
> * removes CipherSuite.java from ProblemList
> 
> Ran the following tests 200 times each with no failures.
> * open/test/jdk/javax/net/ssl/DTLS/ClientAuth.java
> * open/test/jdk/javax/net/ssl/DTLS/PacketLossRetransmission.java
> * open/test/jdk/javax/net/ssl/DTLS/RespondToRetransmit.java
> * open/test/jdk/javax/net/ssl/DTLS/InvalidCookie.java
> * open/test/jdk/javax/net/ssl/DTLS/CipherSuite.java

test/jdk/javax/net/ssl/DTLS/DTLSOverDatagram.java line 560:

> 558:             } catch (Exception exc) {
> 559:                 System.out.println("Exception on client side: ");
> 560:                 exc.printStackTrace(System.out);

can we log these stack traces to System.err?

test/jdk/javax/net/ssl/DTLS/DTLSOverDatagram.java line 591:

> 589: 
> 590:             if (testCase.isGoodJob()) {
> 591:                 throw e;

Why is this flipped, earlier if isGoodJob() returns false then we throw exception.

-------------

PR: https://git.openjdk.org/jdk/pull/11558



More information about the security-dev mailing list