RFR: 8297798: Timeout with DTLSOverDatagram test template [v3]

Matthew Donovan duke at openjdk.org
Thu Dec 15 16:04:33 UTC 2022


On Thu, 15 Dec 2022 15:09:12 GMT, Jamil Nimeh <jnimeh at openjdk.org> wrote:

>> Matthew Donovan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   formatting changes
>
> test/jdk/javax/net/ssl/DTLS/InvalidRecords.java line 42:
> 
>> 40: 
>> 41: /**
>> 42:  * Test that if handshake messages are crasged, the handshake would fail
> 
> crasged?  Was that supposed to be "changed?"

I fixed the typo.

> test/jdk/javax/net/ssl/DTLS/InvalidRecords.java line 66:
> 
>> 64:         if (needInvalidRecords.get() && (ba.length >= 60) &&
>> 65:                 (ba[0x00] == (byte)0x16) && (ba[0x0D] == (byte)0x01) &&
>> 66:                 (ba[0x3B] == (byte)0x00) && (ba[0x3C] > 0)) {
> 
> I just want to make sure - this test is only designed to be run for initial handshakes with cookies, not resumed handshakes, correct?  I assume that is the intent since this test dates back to the initial DTLS release where resumptions didn't use cookies (that was a recent change to include support for resumption cookies).

That's correct. The test driver (DTLSOverDataGram) doesn't do session resumption.

-------------

PR: https://git.openjdk.org/jdk/pull/11558



More information about the security-dev mailing list