RFR: 8298381: Improve handling of session tickets for multiple SSLContexts [v3]

Anthony Scarpino ascarpino at openjdk.org
Thu Dec 22 04:18:51 UTC 2022


On Wed, 21 Dec 2022 20:15:57 GMT, Xue-Lei Andrew Fan <xuelei at openjdk.org> wrote:

>> Volker Simonis has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Optimized initialisation of currentKeyID and deletion of expired session keys as proposed by @schlosna
>
> src/java.base/share/classes/sun/security/ssl/SSLContextImpl.java line 80:
> 
>> 78: 
>> 79:     protected SessionTicketExtension.StatelessKey getKey() {
>> 80:         SessionTicketExtension.StatelessKey ssk = serverCache.getKey();
> 
> I may change the serverCache from private to package private, and move the getKey() methods into SSLSessionContextImpl:
> 
> -    private final SSLSessionContextImpl serverCache;
> +    final SSLSessionContextImpl serverCache;
> 
> 
> Then the caller could use sslContext.serverCache.getKey() directly.  BTW, I may change the name from getKey to getStatelessKey() for readability.

I agree this should be in SSLSessionContextImpl

-------------

PR: https://git.openjdk.org/jdk/pull/11590



More information about the security-dev mailing list