RFR: 8298381: Improve handling of session tickets for multiple SSLContexts [v3]

Volker Simonis simonis at openjdk.org
Thu Dec 22 12:55:00 UTC 2022


On Wed, 21 Dec 2022 20:07:40 GMT, Xue-Lei Andrew Fan <xuelei at openjdk.org> wrote:

>> Volker Simonis has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Optimized initialisation of currentKeyID and deletion of expired session keys as proposed by @schlosna
>
> src/java.base/share/classes/sun/security/ssl/SSLSessionContextImpl.java line 79:
> 
>> 77:     private final Map<Integer,          // Maps session keys to session state
>> 78:             SessionTicketExtension.StatelessKey> keyHashMap = new ConcurrentHashMap<>();
>> 79: 
> 
> It may be not necessary to allocate the map for client session context.  It may be fine to me the map allocation to constructor.
> 
> 
> private final Map<Integer, SessionTicketExtension.StatelessKey> keyHashMap;
> SSLSessionContextImpl(boolean server) {
>     ....
>     if (server) {
>         keyHashMap = ...
>         currentKeyID = ...
>     } else {
>         keyHashMap = empty map
>     }
> }

Changed.

-------------

PR: https://git.openjdk.org/jdk/pull/11590



More information about the security-dev mailing list