RFR: 8280409: JarFile::verifiableEntry can fail with NPE accessing ze.getName() [v2]

Lance Andersen lancea at openjdk.java.net
Tue Feb 8 18:15:06 UTC 2022


On Tue, 8 Feb 2022 15:31:51 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Lance Andersen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Reduce Exception checking to JarFile::verifiableEntry
>
> src/java.base/share/classes/java/util/jar/JarFile.java line 874:
> 
>> 872:             ze = getJarEntry(ze.getName());
>> 873:         } else {
>> 874:             throw new ZipException("Error: ZipEntry::getName returned null!");
> 
> I'd probably leave out the "Error:" and the "!".

OK, I can do that if you prefer.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7348



More information about the security-dev mailing list