RFR: 8280494: (D)TLS signature schemes [v15]
Xue-Lei Andrew Fan
xuelei at openjdk.java.net
Wed Feb 9 22:58:16 UTC 2022
On Wed, 9 Feb 2022 21:38:22 GMT, Sean Mullan <mullan at openjdk.org> wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Spec update
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 749:
>
>> 747: * @implNote
>> 748: * Note that the underlying provider may define the default signature
>> 749: * schemes for each SSL/TLS/DTLS connection. Applications may also use
>
> I think you can remove the first sentence that starts with "Note ..." as you already talk about provider-specific defaults before this. Also @implNotes are usually about the JDK implementation and not any provider. In the second sentence I would be more specific that this applies to the SunJSSE provider (see changes in italics), ex: "Applications ... system properties _with the SunJSSE provider_ to ..."
Sounds good to me. Updated the CSR and PR. Thank you for the review!
@jnimeh Jamil, do you have any comment about the spec and implementation? Otherwise, I will finalize the CSR.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7252
More information about the security-dev
mailing list