RFR: 8274524: SSLSocket.close() hangs if it is called during the ssl handshake [v2]
Alexey Bakhtin
abakhtin at openjdk.java.net
Fri Feb 11 20:07:43 UTC 2022
> Please review the patch for the JDK-8274524
>
> SSLSocket.close() could cause an intermittent hang of the socket read operation. It happens in case of SO_TIMEOUT is set to 0 (infinite timeout).
> SSLSocket.close() reads from the socket as part of the skip() operation to prevent TCP Connection reset (see JDK-8268965). Socket reads are performed in a loop for small chunks. These read operations could cause a deadlock, in case of SO_TIMEOUT = 0
> I suggest to force non-zero SO_TIMEOUT during the skip() operation to prevent such deadlock
>
> This is a second iteration of review. Previous PR was closed without integration: https://github.com/openjdk/jdk/pull/5760
Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision:
Change read timeout value for skip
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7432/files
- new: https://git.openjdk.java.net/jdk/pull/7432/files/7ac94818..6ea30075
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7432&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7432&range=00-01
Stats: 6 lines in 1 file changed: 5 ins; 0 del; 1 mod
Patch: https://git.openjdk.java.net/jdk/pull/7432.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/7432/head:pull/7432
PR: https://git.openjdk.java.net/jdk/pull/7432
More information about the security-dev
mailing list