RFR: 8277976: Break up SEQUENCE in X509Certificate::getSubjectAlternativeNames and X509Certificate::getIssuerAlternativeNames in otherName [v4]

Michael Osipov duke at openjdk.java.net
Tue Feb 15 09:19:09 UTC 2022


On Fri, 11 Feb 2022 17:13:46 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> The enhancement adds two extra items in the `getSubjectAlternativeNames()` output for an OtherName.
>> 
>> It also fix several errors:
>> 1. In `OtherName.java`, `nameValue` should be the value inside `CONTEXT [0]` without the tag and length bytes.
>> 2. The argument in constructor `extClass.getConstructor(Object.class)` is suspicious. Maybe it meant `byte[]`.
>
> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   specifies the type of the 4th element

test/jdk/sun/security/x509/OtherName/Parse.java line 86:

> 84:         int found = 0;
> 85:         for (var san : x.getSubjectAlternativeNames()) {
> 86:             if (san.get(2).equals("1.2.3.5")

Would it make sense to explicitly test length for at least 4?

-------------

PR: https://git.openjdk.java.net/jdk/pull/7167



More information about the security-dev mailing list