RFR: 8277976: Break up SEQUENCE in X509Certificate::getSubjectAlternativeNames and X509Certificate::getIssuerAlternativeNames in otherName [v5]
Sean Mullan
mullan at openjdk.java.net
Tue Feb 15 17:38:14 UTC 2022
On Tue, 15 Feb 2022 15:16:58 GMT, Weijun Wang <weijun at openjdk.org> wrote:
>> The enhancement adds two extra items in the `getSubjectAlternativeNames()` output for an OtherName.
>>
>> It also fix several errors:
>> 1. In `OtherName.java`, `nameValue` should be the value inside `CONTEXT [0]` without the tag and length bytes.
>> 2. The argument in constructor `extClass.getConstructor(Object.class)` is suspicious. Maybe it meant `byte[]`.
>
> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
>
> string at 4th place
src/java.base/share/classes/java/security/cert/X509Certificate.java line 600:
> 598: * defined for otherNames, X.400 names, EDI party names, or any
> 599: * other type of names. They are returned as byte arrays
> 600: * containing the ASN.1 DER encoded form of the name.
I would move this sentence up before "otherNames ..." and remove the "otherNames" from it and the end of the sentence. So basically:
> * No standard string format is
> * defined for X.400 names or EDI party names. They are returned as byte arrays
> * containing the ASN.1 DER encoded form of the name.
> * otherNames are returned as a byte array ...
-------------
PR: https://git.openjdk.java.net/jdk/pull/7167
More information about the security-dev
mailing list