RFR: 8277976: Break up SEQUENCE in X509Certificate::getSubjectAlternativeNames and X509Certificate::getIssuerAlternativeNames in otherName [v6]

[Sean Mullan]

On Tue, 15 Feb 2022 19:51:57 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> The enhancement adds two extra items in the `getSubjectAlternativeNames()` output for an OtherName.
>> 
>> It also fix several errors:
>> 1. In `OtherName.java`, `nameValue` should be the value inside `CONTEXT [0]` without the tag and length bytes.
>> 2. The argument in constructor `extClass.getConstructor(Object.class)` is suspicious. Maybe it meant `byte[]`.
>
> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   retell the formats

src/java.base/share/classes/java/security/cert/X509Certificate.java line 597:

> 595:      * in string form, and a fourth entry for their {@code value} as either
> 596:      * a string (if the value is a valid supported character string)
> 597:      * or (otherwise) a byte array containing the ASN.1 DER encoded from of

typo: s/from/form/

src/java.base/share/classes/java/security/cert/X509Certificate.java line 612:

> 610:      *
> 611:      * @implNote The JDK SUN provider supports the third and fourth
> 612:      * otherName elements.

I would probably use "entries" instead of "elements" to be consistent with the previous wording.

test/jdk/sun/security/x509/OtherName/Parse.java line 27:

> 25:  * @test
> 26:  * @bug 8277976
> 27:  * @summary Break up SEQUENCE in X509Certiticate::getSubjectAlternativeNames

Typo: s/X509Certiticate/X509Certificate/ 
(also on line 28)

-------------

PR: https://git.openjdk.java.net/jdk/pull/7167