RFR: 8277976: Break up SEQUENCE in X509Certificate::getSubjectAlternativeNames and X509Certificate::getIssuerAlternativeNames in otherName [v6]

Weijun Wang weijun at openjdk.java.net
Thu Feb 17 03:13:15 UTC 2022


On Thu, 17 Feb 2022 03:07:12 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> src/java.base/share/classes/java/security/cert/X509Certificate.java line 595:
>> 
>>> 593:      * returned as byte arrays containing the ASN.1 DER encoded form of the
>>> 594:      * name. There may be a third entry in the list for their {@code type-id}
>>> 595:      * in string form, and a fourth entry for their {@code value} as either
>> 
>> I think "its" is more grammatically correct than "their".
>
> The whole paragraph uses plural forms like "IPv4 address names are" and "OID names are", so I also use "otherNames are" and "their". I admit I don't feel comfortable too.

I thought about "the", but it does not show the belong to relation.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7167



More information about the security-dev mailing list