RFR: 8277976: Break up SEQUENCE in X509Certificate::getSubjectAlternativeNames and X509Certificate::getIssuerAlternativeNames in otherName [v8]

Weijun Wang weijun at openjdk.java.net
Fri Feb 18 20:05:47 UTC 2022


On Thu, 17 Feb 2022 16:00:46 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> The enhancement adds two extra items in the `getSubjectAlternativeNames()` output for an OtherName.
>> 
>> It also fix several errors:
>> 1. In `OtherName.java`, `nameValue` should be the value inside `CONTEXT [0]` without the tag and length bytes.
>> 2. The argument in constructor `extClass.getConstructor(Object.class)` is suspicious. Maybe it meant `byte[]`.
>
> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   s/can/may/

> _Mailing list message from Michael StJohns...

I'll use your exception message on not a `[0]`.

For dealing with the error while the parsing of `nameValue`, we've discussed it and my last comment is at https://github.com/openjdk/jdk/pull/7167#discussion_r810155556. I'd rather not fail.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7167



More information about the security-dev mailing list