RFR: 8282158: ECParameters InvalidParameterSpecException messages missed ECKeySizeParameterSpec

Xue-Lei Andrew Fan xuelei at openjdk.java.net
Mon Feb 21 07:06:50 UTC 2022


On Mon, 21 Feb 2022 04:49:42 GMT, John Jiang <jjiang at openjdk.org> wrote:

> sun.security.util.ECParameters class supports three AlgorithmParameterSpec types, exactly ECParameterSpec, ECGenParameterSpec and ECKeySizeParameterSpec, however the InvalidParameterSpecException messages missed ECKeySizeParameterSpec.

Marked as reviewed by xuelei (Reviewer).

src/java.base/share/classes/sun/security/util/ECParameters.java line 127:

> 125:             throw new InvalidParameterSpecException
> 126:                 ("Only ECParameterSpec, ECGenParameterSpec " +
> 127:                         "and ECKeySizeParameterSpec supported");

Would you mind reducing the leading whitespaces of the 2nd line so that the two lines are aligned?  It would be nice to move the '9' to the previous line, as you are already there.

src/java.base/share/classes/sun/security/util/ECParameters.java line 218:

> 216:         throw new InvalidParameterSpecException(
> 217:             "Only ECParameterSpec, ECGenParameterSpec " +
> 218:                     "and ECKeySizeParameterSpec supported");

Would you mind reducing the leading whitespaces so that the two lines are aligned?

-------------

PR: https://git.openjdk.java.net/jdk/pull/7550



More information about the security-dev mailing list