RFR: 8281525: Enable Zc:strictStrings flag in Visual Studio build [v2]

Magnus Ihse Bursie ihse at openjdk.java.net
Tue Feb 22 16:43:30 UTC 2022


On Tue, 22 Feb 2022 14:13:43 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> make/autoconf/flags-cflags.m4 line 136:
>> 
>>> 134:       CFLAGS_WARNINGS_ARE_ERRORS="-WX"
>>> 135: 
>>> 136:       WARNINGS_ENABLE_ALL="-W3 -Zc:strictStrings"
>> 
>> This is not strictly a flag to enable warnings. I'd recommend you move it to line 499 and 500 in the same file, which would align it with the -Zc:wchar_t- switch. Make sure you add it to both TOOLCHAIN_CFLAGS_JVM and TOOLCHAIN_CFLAGS_JDK.
>
> Done

Did you forget to push the fix?

-------------

PR: https://git.openjdk.java.net/jdk/pull/7565



More information about the security-dev mailing list