RFR: 8273042: TLS Certificate Compression

Jamil Nimeh jnimeh at openjdk.java.net
Mon Feb 28 19:47:35 UTC 2022


On Wed, 23 Feb 2022 20:15:24 GMT, Xue-Lei Andrew Fan <xuelei at openjdk.org> wrote:

> Hi,
> 
> Please review the implementation of RFC 8879, TLS Certificate Compression, in JDK.  The TLS Certificate Compression standard is an essential part for QUIC connections and performance improvement for TLS connections.  More details, please refer to the [JEP](https://bugs.openjdk.java.net/browse/JDK-8281710) proposal.
> 
> The JEP was submitted, and it may take time for the final approval.  But let me know you ideas and concerns about the proposal and implementation.
> 
> JEP: https://bugs.openjdk.java.net/browse/JDK-8281710

src/java.base/share/classes/sun/security/ssl/CompressionAlgorithm.java line 49:

> 47:     }
> 48: 
> 49:     static CompressionAlgorithm nameOf(String name) {

Shouldn't this be valueOf?  We're not consistent in the method name across all our sun.security.ssl enumerations, but more often than not when we return the enumeration object it's via a valueOf call.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7599



More information about the security-dev mailing list