[jdk18] RFR: 8279222: Incorrect legacyMap.get in java.security.Provider after JDK-8276660 [v3]

[Aleksey Shipilev]

> SonarCloud reports:
>  A "Map<ServiceKey, Service>" cannot contain a "String" in a "ServiceKey" type.
> 
> 
>      // clean up old alias if present
>      Service prevAliasService = legacyMap.get(aliasAlg);
> 
> 
> Should be `aliasKey`, like other accesses to `legacyMap`. This code is introduced by [JDK-8276660](https://bugs.openjdk.java.net/browse/JDK-8276660), so it affects JDK 18.
> 
> Additional testing:
>  - [x] Linux x86_64 fastdebug `jdk_security`

Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:

 - Whitespace
 - Metadata updates
 - Merge branch 'master' into JDK-8279222-jsp-get
 - Test addition by Valerie
 - Merge branch 'master' into JDK-8279222-jsp-get
 - Fix

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk18/pull/70/files
  - new: https://git.openjdk.java.net/jdk18/pull/70/files/9c6af4bb..590442dc

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk18&pr=70&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk18&pr=70&range=01-02

  Stats: 528 lines in 43 files changed: 430 ins; 0 del; 98 mod
  Patch: https://git.openjdk.java.net/jdk18/pull/70.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk18 pull/70/head:pull/70

PR: https://git.openjdk.java.net/jdk18/pull/70