RFR: 8279800: isAssignableFrom checks in AlgorithmParametersSpi.engineGetParameterSpec appear to be backwards

Weijun Wang weijun at openjdk.java.net
Wed Jan 12 19:49:30 UTC 2022


On Wed, 12 Jan 2022 19:41:31 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Change the order so parent class is at the left.
>
> test/jdk/java/security/spec/IsAssignableFromOrder.java line 72:
> 
>> 70:     static void test(String algorithm, AlgorithmParameterSpec spec,
>> 71:             Class<? extends AlgorithmParameterSpec>... classes) throws Exception {
>> 72:         var ap1 = AlgorithmParameters.getInstance(algorithm);
> 
> nit: Print out the algorithm which has been tested?

I can, but if an exception is thrown, I can find out which algorithm has a problem by looking at the line number.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7037



More information about the security-dev mailing list