RFR: 8280122: SupportedGroupsExtension should output "named groups" rather than "versions"

Weijun Wang weijun at openjdk.java.net
Tue Jan 18 16:30:28 UTC 2022


On Tue, 18 Jan 2022 16:13:42 GMT, Xue-Lei Andrew Fan <xuelei at openjdk.org> wrote:

>> MessageFormat messageFormat = new MessageFormat(
>>     ""versions": '['{0}']'", Locale.ENGLISH);
>> 
>> In class SupportedGroupsExtension, the above "versions" should be "named groups".
>
> src/java.base/share/classes/sun/security/ssl/SupportedGroupsExtension.java line 115:
> 
>> 113:         public String toString() {
>> 114:             MessageFormat messageFormat = new MessageFormat(
>> 115:                 "\"named groups\": '['{0}']'", Locale.ENGLISH);
> 
> Per the TLS specification, it may be a more instinctive to use  "supported groups".  It is not a big concern, no additional approval is required to me if you want an update.

If so, should the `SupportedVersionsExtension` get a more precise description as well?

-------------

PR: https://git.openjdk.java.net/jdk/pull/7123



More information about the security-dev mailing list