RFR: JDK-8284851 Update javax.crypto files to use proper javadoc for mentioned classes [v6]
Weijun Wang
weijun at openjdk.org
Wed Jul 6 14:30:52 UTC 2022
On Tue, 5 Jul 2022 15:37:55 GMT, Mark Powers <duke at openjdk.org> wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional commit since the last revision:
>
> aw shucks - another one
Last comments.
src/java.base/share/classes/java/security/AllPermission.java line 183:
> 181: *
> 182: * @throws IllegalArgumentException if the permission is not an
> 183: * {@crypto AllPermission}
Typo, `s/crypto/code/`.
src/java.base/share/classes/java/security/CodeSource.java line 307:
> 305: * and {@code null} certificates all imply
> 306: * the codesource with the location "http://www.example.com/classes/foo.jar"
> 307: * and {@code null} certificates:
Should the URL in the line above be wrapped in `{@code}`?
src/java.base/share/classes/javax/crypto/CryptoPermissions.java line 135:
> 133: * object is marked as readonly.
> 134: *
> 135: * @see isReadOnly
Should be `PermissionCollection#isReadOnly`.
-------------
PR: https://git.openjdk.org/jdk/pull/9282
More information about the security-dev
mailing list