RFR: 8289768: Clean up unused code [v2]

Daniel Jeliński djelinski at openjdk.org
Wed Jul 6 05:32:29 UTC 2022


> This patch removes many unused variables and one unused label reported by the compilers when relevant warnings are enabled. 
> 
> The unused code was found by compiling after removing `unused` from the list of disabled warnings for [gcc](https://github.com/openjdk/jdk/blob/master/make/autoconf/flags-cflags.m4#L190) and [clang](https://github.com/openjdk/jdk/blob/master/make/autoconf/flags-cflags.m4#L203), and enabling [C4189](https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4189?view=msvc-170) MSVC warning.
> 
> I only removed variables that were uninitialized or initialized without side effects. I verified that the removed variables were not used in any `#ifdef`'d code. I checked that the changed code still compiles on Windows, Linux and Mac, both in release and debug versions.

Daniel Jeliński has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - Merge remote-tracking branch 'origin' into unused-variables
 - Remove unused variables (windows)
 - Remove unused variables (macos)
 - Remove unused variables (linux)

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/9383/files
  - new: https://git.openjdk.org/jdk/pull/9383/files/915680c0..b4cd5374

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=9383&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=9383&range=00-01

  Stats: 491 lines in 22 files changed: 458 ins; 5 del; 28 mod
  Patch: https://git.openjdk.org/jdk/pull/9383.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/9383/head:pull/9383

PR: https://git.openjdk.org/jdk/pull/9383



More information about the security-dev mailing list