[jdk19] RFR: 8287809: Revisit implementation of memory session [v4]

Jorn Vernee jvernee at openjdk.org
Wed Jul 6 17:11:54 UTC 2022


On Fri, 17 Jun 2022 18:39:03 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> This is a JDK 19 clone of: https://github.com/openjdk/jdk/pull/9017
>
> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert implicit vs. heap session changes

src/java.base/share/classes/java/lang/invoke/X-VarHandleSegmentView.java.template line 131:

> 129:         AbstractMemorySegmentImpl bb = checkAddress(obb, base, handle.length, true);
> 130: #if[floatingPoint]
> 131:         $rawType$ rawValue = SCOPED_MEMORY_ACCESS.get$RawType$Unaligned(bb.session(),

For instance, it's not clear to me why `baseSession()` is not called here.

src/java.base/share/classes/jdk/internal/foreign/abi/aarch64/macos/MacOsAArch64VaList.java line 172:

> 170: 
> 171:         public Builder(MemorySession session) {
> 172:             ((MemorySessionImpl)session).checkValidState();

Or here, if the memory session is a non-closeable view.

-------------

PR: https://git.openjdk.org/jdk19/pull/22



More information about the security-dev mailing list