RFR: JDK-8284851 Update javax.crypto files to use proper javadoc for mentioned classes [v7]
Valerie Peng
valeriep at openjdk.org
Thu Jul 7 17:18:27 UTC 2022
On Thu, 7 Jul 2022 02:45:42 GMT, Mark Powers <duke at openjdk.org> wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 13 additional commits since the last revision:
>
> - Merge
> - comments from Valerie and Max
> - aw shucks - another one
> - Max comments continued
> - Max comments
> - Valerie fix continued
> - Valerie fix
> - mo polish
> - polish
> - Merge
> - ... and 3 more: https://git.openjdk.org/jdk/compare/88dd9d95...54310a1a
src/java.base/share/classes/javax/crypto/MacSpi.java line 96:
> 94: /**
> 95: * Processes {@code input.remaining()} bytes in the ByteBuffer
> 96: * {@code input}, starting at {@code input.position()}.
Hmm, should these be {@code input}.remaining() and {@code input}.position()?
src/java.base/share/classes/javax/crypto/SealedObject.java line 43:
> 41: * confidentiality with a cryptographic algorithm.
> 42: *
> 43: * <p> Given any Serializable object, one can create a {@code SealedObject}
add {@code } to Serializable?
src/java.base/share/classes/javax/crypto/SealedObject.java line 125:
> 123: * encoded in the default format.
> 124: * <p>
> 125: * That is, {@code cipher.getParameters().getEncoded()}.
cipher -> Cipher?
src/java.base/share/classes/javax/crypto/SealedObject.java line 132:
> 130:
> 131: /**
> 132: * Constructs a {@code SealedObject} from any Serializable object.
add {@code } to Serializable?
src/java.base/share/classes/javax/crypto/SealedObject.java line 227:
> 225: * the sealing operation.
> 226: * If the default provider package provides an implementation of that
> 227: * algorithm, an instance of {@code Cipher} object containing that
"an instance of" seems redundant now that you added "object"
-------------
PR: https://git.openjdk.org/jdk/pull/9282
More information about the security-dev
mailing list