RFR: 8289768: Clean up unused code [v2]
Daniel Jeliński
djelinski at openjdk.org
Fri Jul 8 07:08:50 UTC 2022
On Thu, 7 Jul 2022 19:06:52 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:
>> Daniel Jeliński has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>>
>> - Merge remote-tracking branch 'origin' into unused-variables
>> - Remove unused variables (windows)
>> - Remove unused variables (macos)
>> - Remove unused variables (linux)
>
> src/jdk.hotspot.agent/linux/native/libsaproc/symtab.c line 308:
>
>> 306: ELF_SHDR* shbuf = NULL;
>> 307: ELF_SHDR* cursct = NULL;
>> 308: ELF_PHDR* phbuf = NULL;
>
> phbuf is also essentially unused. The only reference is to free it if non-null, but it's always NULL, so that code can be removed too.
Good catch! Also removed similar code from macOS version.
-------------
PR: https://git.openjdk.org/jdk/pull/9383
More information about the security-dev
mailing list