RFR: 8215916: The failure reason of an optional JAAS LoginModule is not logged

Weijun Wang weijun at openjdk.org
Fri Jul 8 13:15:31 UTC 2022


On Tue, 14 Jun 2022 19:07:24 GMT, Jayashree Huttanagoudar <duke at openjdk.org> wrote:

> Could you please review the changes?
> This patch is to address : https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug

`SmartLoginModule.java` is a class used by a test, itself is not one since there's no `main()` method.

Your new test needs to be a regression test, which means before the fix it fails and after the fix it succeeds. Also, seeing the exception message in a jtreg output with your own eyes is not a test. The test itself should detect the exception and decide whether it's a success or a failure. In the case, I'd recommend you use the `System.setErr` method to store the output into a `ByteArrayOutputStream` and then look into it.

-------------

PR: https://git.openjdk.org/jdk/pull/9159



More information about the security-dev mailing list