RFR: 8289768: Clean up unused code [v3]

Michael McMahon michaelm at openjdk.org
Mon Jul 11 07:00:45 UTC 2022


On Fri, 8 Jul 2022 07:08:46 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> This patch removes many unused variables and one unused label reported by the compilers when relevant warnings are enabled. 
>> 
>> The unused code was found by compiling after removing `unused` from the list of disabled warnings for [gcc](https://github.com/openjdk/jdk/blob/master/make/autoconf/flags-cflags.m4#L190) and [clang](https://github.com/openjdk/jdk/blob/master/make/autoconf/flags-cflags.m4#L203), and enabling [C4189](https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4189?view=msvc-170) MSVC warning.
>> 
>> I only removed variables that were uninitialized or initialized without side effects. I verified that the removed variables were not used in any `#ifdef`'d code. I checked that the changed code still compiles on Windows, Linux and Mac, both in release and debug versions.
>
> Daniel Jeliński has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Update copyright
>  - Remove more unused variables

libnet changes look fine to me

-------------

Marked as reviewed by michaelm (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9383


More information about the security-dev mailing list