RFR: 8289275: Remove incorrect __declspec(dllimport) attributes from pointers in jdk.crypto.cryptoki

Julian Waters jwaters at openjdk.org
Thu Jul 14 02:26:58 UTC 2022


On Wed, 13 Jul 2022 16:40:48 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

> > > pkcs11.h is a standard header file from OASIS. Best to leave it alone. Just my .02.
> > 
> > 
> > The only change to pkcs11.h is in a comment though, the other changes are outside the ANSI C headers from the standard. Should I just revert the comment in that case?
> 
> Sounds good to me. Will take a look at the rest of changes in a day or two. Thanks!

Alright, will do. I also do want to look at p11_md.h to see if my changes are appropriate in the meantime, as I have a feeling it can be accomplished somewhat more elegantly

Thanks for the review!

-------------

PR: https://git.openjdk.org/jdk/pull/9353



More information about the security-dev mailing list