RFR: 8215916: The failure reason of an optional JAAS LoginModule is not logged [v2]

Weijun Wang weijun at openjdk.org
Sat Jul 16 13:36:13 UTC 2022


On Fri, 15 Jul 2022 13:05:38 GMT, Jayashree Huttanagoudar <duke at openjdk.org> wrote:

>> Could you please review the changes?
>> This patch is to address : https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add test case to verify the patch

There are quite some JAAS tests inside `test/jdk/javax/security/auth/login` where you can copy. The one you found has a very old copyright header and invalid format (like trailing spaces...). Also, I don't think it's worth implementing a new principal and a new login module. You can just using the out-of-box UnixLoginModule and NTLoginModule.

-------------

PR: https://git.openjdk.org/jdk/pull/9159



More information about the security-dev mailing list