RFR: 8290775: Some doc errors in DerOutputStream.java [v2]
jquanC
duke at openjdk.org
Fri Jul 22 08:27:38 UTC 2022
> There are some doc errors in sun.security.util.DerOutputStream, like the followings,
>
>
> /**
> * Private helper routine for writing DER encoded string values.
> * @param s the string to write
> * @param stringTag one of the DER string tags that indicate which
> * encoding should be used to write the string out.
> * @param enc the name of the encoder that should be used corresponding
> * to the above tag.
> */
> private void writeString(String s, byte stringTag, Charset charset) throws IOException
>
> The parameter is charset, but not enc.
>
>
> /**
> * Marshals a DER integer on the output stream.
> *
> * @param i the integer in bytes, equivalent to BigInteger::toByteArray.
> */
> public void putInteger(byte[] buf) throws IOException {
>
> The parameter is buf, but not i.
jquanC has updated the pull request incrementally with one additional commit since the last revision:
8290775: Some doc errors in DerOutputStream.java Update: better improvement
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/9585/files
- new: https://git.openjdk.org/jdk/pull/9585/files/c6f17c8f..c2a0a8b1
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=9585&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=9585&range=00-01
Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
Patch: https://git.openjdk.org/jdk/pull/9585.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/9585/head:pull/9585
PR: https://git.openjdk.org/jdk/pull/9585
More information about the security-dev
mailing list