RFR: 8290775: Some doc errors in DerOutputStream.java [v3]

[jquanC]

On Fri, 22 Jul 2022 15:11:43 GMT, Xue-Lei Andrew Fan <xuelei at openjdk.org> wrote:

>> jquanC has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8290775: Some doc errors in DerOutputStream.java  Update:correct the tense problem of expression
>
> src/java.base/share/classes/sun/security/util/DerOutputStream.java line 464:
> 
>> 462:      * @param stringTag one of the DER string tags that indicate which
>> 463:      * encoding should be used to write the string out.
>> 464:      * @param charset the charset should be used corresponding to the
> 
> I may suggest to add 'that' back.  Without it, the meaning of the sentence may be different.
> 
> ... the charset should be used corresponding to the above tag.
> vs
> ... the charset **that** should be used corresponding to the above tag.

Thanks again for all the above suggestions sincerely!
To avoid adding your troubles, I should end up using the following expression:

the charset that should be used corresponding to the above tag.

I'm trying to understand the difference between the two.
The first sentence may be understood as "the process of using charset" according to the above label.
The second sentence(use that) can better express "the choice of charset" needs to be based on the above label.
Is this correct?

-------------

PR: https://git.openjdk.org/jdk/pull/9585