RFR: 8290775: Some doc errors in DerOutputStream.java [v4]

jquanC duke at openjdk.org
Fri Jul 22 16:29:55 UTC 2022


> There are some doc errors in sun.security.util.DerOutputStream, like the followings,
> 
> 
> /**
>  * Private helper routine for writing DER encoded string values.
>  * @param s the string to write
>  * @param stringTag one of the DER string tags that indicate which
>  * encoding should be used to write the string out.
>  * @param enc the name of the encoder that should be used corresponding
>  * to the above tag.
>  */
> private void writeString(String s, byte stringTag, Charset charset) throws IOException
> 
> The parameter is charset, but not enc.
> 
> 
> /**
>  * Marshals a DER integer on the output stream.
>  *
>  * @param i the integer in bytes, equivalent to BigInteger::toByteArray.
>  */
> public void putInteger(byte[] buf) throws IOException {
> 
> The parameter is buf, but not i.

jquanC has updated the pull request incrementally with one additional commit since the last revision:

  8290775: Some doc errors in DerOutputStream.java  Update: better expression

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/9585/files
  - new: https://git.openjdk.org/jdk/pull/9585/files/c2a05304..b8b25f25

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=9585&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=9585&range=02-03

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/9585.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/9585/head:pull/9585

PR: https://git.openjdk.org/jdk/pull/9585


More information about the security-dev mailing list