RFR: 6227536: KeyGenerator.init() methods do not throw IllegalArgumentException for keysize == 0 [v2]

Sean Mullan mullan at openjdk.org
Thu Jul 28 20:58:46 UTC 2022


On Thu, 28 Jul 2022 20:54:08 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> src/java.base/share/classes/com/sun/crypto/provider/HmacMD5KeyGenerator.java line 93:
>> 
>>> 91: 
>>> 92:         if (keysize <= 0) {
>>> 93:             throw new IllegalArgumentException("keysize must not be <= 0 for SunJCE");
>> 
>> < 80 chars please
>
> The "for SunJCE" is odd to see in an exception message, I would leave that out.

A stack trace of the exception should be sufficient to tell what provider/code is generating it.

-------------

PR: https://git.openjdk.org/jdk/pull/9679


More information about the security-dev mailing list