RFR: 6227536: KeyGenerator.init() methods do not throw IllegalArgumentException for keysize == 0 [v9]

Kevin Driver kdriver at openjdk.org
Fri Jul 29 20:17:34 UTC 2022


On Fri, 29 Jul 2022 20:07:20 GMT, Bradford Wetmore <wetmore at openjdk.org> wrote:

>> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   put back standard if block, since we never hit the failure case
>
> test/jdk/com/sun/crypto/provider/KeyGenerator/Test6227536.java line 50:
> 
>> 48: 
>> 49:     public static void main(String[] args) throws Exception {
>> 50:         Test6227536 test = new Test6227536();
> 
> Calling the constructor just to get the class name seems redundant, as the test name will appear in all of the jtreg test output.  I would probably pull it out, just my $0.02.

Ack. It's also a nice pattern for avoiding issues with `main` being `static`.

-------------

PR: https://git.openjdk.org/jdk/pull/9679



More information about the security-dev mailing list