RFR: 8287696: Avoid redundant Hashtable.containsKey call in JarVerifier.doneWithMeta

Jaikiran Pai jpai at openjdk.java.net
Mon Jun 6 13:30:41 UTC 2022


On Sat, 28 May 2022 12:00:00 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

> Hashtable doesn't allow `null` values. So, instead of pair `containsKey`/`remove` calls, we can directly call `remove` and then compare result with `null`.
> https://github.com/openjdk/jdk/blob/2c461acfebd28fe5ef62805cbb004f91a3b18f08/src/java.base/share/classes/java/util/jar/JarVerifier.java#L433-L436

Looks fine to me. Please wait for another review before merging.

-------------

Marked as reviewed by jpai (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8935



More information about the security-dev mailing list