RFR: 8209935: Test to cover CodeSource.getCodeSigners() [v4]

Sean Mullan mullan at openjdk.java.net
Thu Jun 9 21:19:04 UTC 2022


On Wed, 8 Jun 2022 10:30:45 GMT, Sibabrata Sahoo <ssahoo at openjdk.org> wrote:

>> A Test updated to cover the getCodeSigners.
>
> Sibabrata Sahoo has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8209935: Test to cover CodeSource.getCodeSigners()

Marked as reviewed by mullan (Reviewer).

test/jdk/java/security/CodeSource/CertsMatch.java line 27:

> 25:  * @test
> 26:  * @bug 6299163
> 27:  * @summary REGRESSION: java.security.CodeSource#equals not symmetric

I think you should remove this line about "REGRESSION" as the summary is supposed to be about what the test is testing. Suggest changing this to summarize what methods are being tested.

-------------

PR: https://git.openjdk.org/jdk/pull/8286



More information about the security-dev mailing list