RFR: 8286779: javax.crypto.CryptoPolicyParser#isConsistent always returns 'true' [v3]

Hai-May Chao hchao at openjdk.java.net
Fri Jun 10 21:41:50 UTC 2022


On Fri, 10 Jun 2022 17:31:56 GMT, Rajan Halade <rhalade at openjdk.org> wrote:

>> Hai-May Chao has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed copyright
>
> test/jdk/javax/crypto/CryptoPermissions/InconsistentEntries.java line 38:
> 
>> 36: import java.security.Security;
>> 37: 
>> 38: // This is a manual test to test a custom “default_local.policy" containing inconsistent entries
> 
> Thanks for the instructions. For manual test, I would rather have these as a System.out on test start than a comment here. This helps engineers who look at jtr file for failure analysis as they generally won't refer test source code to understand missing steps.

Good point. Made the changes as suggested. Thanks for the review.

-------------

PR: https://git.openjdk.org/jdk/pull/8985



More information about the security-dev mailing list