RFR: JDK-8285263 Minor cleanup could be done in java.security [v6]

Weijun Wang weijun at openjdk.java.net
Fri Jun 10 21:52:08 UTC 2022


On Fri, 10 Jun 2022 21:27:58 GMT, Mark Powers <duke at openjdk.java.net> wrote:

>> https://bugs.openjdk.java.net/browse/JDK-8285263 Minor cleanup could be done in java.security
>> 
>> JDK-8273046 is the umbrella bug for this bug. The changes were too large for a single code review, so it was decided to split into smaller chunks. This is one such chunk: 
>> 
>> open/src/java.base/share/classes/java/security
>
> Mark Powers has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - bad grammar
>  - Max comments

Looks good to me now. For `Provider$ServiceKey::matches`, maybe you can add a comment on why `==` is correct. For other changes suggested by IntelliJ, maybe just follow them to make the IDE silent. You decide it.

-------------

Marked as reviewed by weijun (Reviewer).

PR: https://git.openjdk.org/jdk/pull/8319



More information about the security-dev mailing list