Integrated: 8287696: Avoid redundant Hashtable.containsKey call in JarVerifier.doneWithMeta

Andrey Turbanov aturbanov at openjdk.java.net
Sat Jun 11 10:57:00 UTC 2022


On Sat, 28 May 2022 12:00:00 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

> Hashtable doesn't allow `null` values. So, instead of pair `containsKey`/`remove` calls, we can directly call `remove` and then compare result with `null`.
> https://github.com/openjdk/jdk/blob/2c461acfebd28fe5ef62805cbb004f91a3b18f08/src/java.base/share/classes/java/util/jar/JarVerifier.java#L433-L436

This pull request has now been integrated.

Changeset: f1143b1b
Author:    Andrey Turbanov <aturbanov at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/f1143b1b57683665c81d24ff192a9babc30f28ea
Stats:     7 lines in 1 file changed: 0 ins; 5 del; 2 mod

8287696: Avoid redundant Hashtable.containsKey call in JarVerifier.doneWithMeta

Reviewed-by: jpai, lancea

-------------

PR: https://git.openjdk.org/jdk/pull/8935


More information about the security-dev mailing list