RFR: JDK-8288207: Enhance MalformedURLException in Uri.parseCompat [v3]

[Alan Bateman]

On Tue, 14 Jun 2022 11:36:36 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> When trying to construct an LdapURL object with a bad input string (in this example the _ in ad_jbs is causing issues), and not using
>> the backward compatibility flag -Dcom.sun.jndi.ldapURLParsing="legacy" we run into the exception below :
>> 
>> import com.sun.jndi.ldap.LdapURL;
>>  ....
>> String url = "ldap://ad_jbs.ttt.net:389/xyz"; // bad input string containing _
>> LdapURL ldapUrl = new LdapURL(url);
>> 
>> 
>> java --add-opens java.naming/com.sun.jndi.ldap=ALL-UNNAMED LdapParseUrlTest
>> Exception in thread "main" javax.naming.NamingException: Cannot parse url: ldap://ad_jbs.ttt.net:389/xyz [Root exception is java.net.MalformedURLException: unsupported authority: ad_jbs.ttt.net:389]
>> at java.naming/com.sun.jndi.ldap.LdapURL.<init>(LdapURL.java:115)
>> at LdapParseUrlTest.main(LdapParseUrlTest.java:9)
>> Caused by: java.net.MalformedURLException: unsupported authority: ad_jbs.ttt.net:389
>> at java.naming/com.sun.jndi.toolkit.url.Uri.parseCompat(Uri.java:367)
>> at java.naming/com.sun.jndi.toolkit.url.Uri.parse(Uri.java:230)
>> at java.naming/com.sun.jndi.toolkit.url.Uri.init(Uri.java:174)
>> at java.naming/com.sun.jndi.ldap.LdapURL.<init>(LdapURL.java:105)
>> 
>> I would like to add the host and port info to the exception (in the example it is host:port of URI:null:-1] ) so that it is directly visible that the input caused the construction of a URI
>> with "special"/problematic host and port values.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix copy paste error

src/java.naming/share/classes/com/sun/jndi/toolkit/url/Uri.java line 368:

> 366:                         // throw if we have user info or regname
> 367:                         throw new MalformedURLException("Authority component is not server-based, or contains user info. Unsupported authority: " + auth);
> 368:                     }

This looks okay but you may have to split up the line to avoid adding a 150+ char line (most of the file seems to keep the lines under 100 or so).

-------------

PR: https://git.openjdk.org/jdk/pull/9126