[Internet]Re: SSLExtension: Bug/typo in unsupported extension

[xueleifan(XueleiFan)]

On Jun 20, 2022, at 7:38 AM, Ben Smyth <subscriptions at bensmyth.com<mailto:subscriptions at bensmyth.com>> wrote:

Xuelei,

You're right, OpenJDK/jdk GitHub is correct. I was looking at hg.openjdk.java.net/jdk/jdk<http://hg.openjdk.java.net/jdk/jdk>, specifically

    https://hg.openjdk.java.net/jdk/jdk/file/ee1d592a9f53/src/java.base/share/classes/sun/security/ssl/SSLExtension.java


I see.  The Github repository is used now, and the hg repository above may be discontinued.

Xuelei



Ben

On Mon, 20 Jun 2022 at 16:19, xueleifan(XueleiFan) <xueleifan at tencent.com<mailto:xueleifan at tencent.com>> wrote:
Would you mind post the source code or the repository link?  It looks like the code<https://urldefense.com/v3/__https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/sun/security/ssl/SSLExtension.java__;!!ACWV5N9M2RV99hQ!JN_NGx0FSR1eqgQsiUqxhPXr6Oh4N-ukcgtoAJTN2M-6ingXT29z2bVeRcYyGuVSt9WVaJBcTfpIHPz1muEo582J$ > is good in OpenJDK/jdk GitHub.

Regards,
Xuelei

On Jun 20, 2022, at 5:48 AM, Ben Smyth <subscriptions at bensmyth.com<mailto:subscriptions at bensmyth.com>> wrote:

We have

    // extensions defined in RFC 7250
    CLIENT_CERT_TYPE        (0x0013, "padding"),
    SERVER_CERT_TYPE        (0x0014, "server_certificate_type"),

    // extensions defined in RFC 7685
    PADDING                 (0x0015, "client_certificate_type"),

We should have

    // extensions defined in RFC 7250
    CLIENT_CERT_TYPE        (0x0013, "client_certificate_type"),
    SERVER_CERT_TYPE        (0x0014, "server_certificate_type"),

    // extensions defined in RFC 7685
    PADDING                 (0x0015, "padding"),


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/security-dev/attachments/20220620/e5be254b/attachment.htm>