Integrated: 8288209: SSL debug message wrong about unsupported authentication scheme
Weijun Wang
weijun at openjdk.org
Tue Jun 21 14:36:53 UTC 2022
On Mon, 13 Jun 2022 14:53:51 GMT, Weijun Wang <weijun at openjdk.org> wrote:
> At the beginning, this bug was about the incorrect warning message "Unsupported authentication scheme" on line 1051 which should have been "This key algorithm has been checked, skip it".
>
> Now, it's a code refactoring that emphasizes only the key algorithm inside a signature scheme is checked in these two methods, and therefore the ignore-if-checked logic in the old code is correct.
>
> Note: `logWarning` is put inside `SSLLogger` so we can get the correct caller line number. Also, please advise if the `|| SSLLogger.logWarning` style looks weird and if there is a better way to filter and log at the same time.
This pull request has now been integrated.
Changeset: 19017358
Author: Weijun Wang <weijun at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/19017358b1b3c63fdddc1eecb2fe52f7b7d4b6e3
Stats: 106 lines in 5 files changed: 9 ins; 57 del; 40 mod
8288209: SSL debug message wrong about unsupported authentication scheme
Reviewed-by: djelinski, jnimeh
-------------
PR: https://git.openjdk.org/jdk/pull/9140
More information about the security-dev
mailing list