RFR: 8288985: P11TlsKeyMaterialGenerator should work with ChaCha20-Poly1305 [v2]

Valerie Peng valeriep at openjdk.org
Thu Jun 23 23:03:58 UTC 2022


On Thu, 23 Jun 2022 21:35:46 GMT, zzambers <duke at openjdk.org> wrote:

>> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11SecretKeyFactory.java line 104:
>> 
>>> 102:         if ("ChaCha20-Poly1305".equals(algorithm)) {
>>> 103:             algorithm = "ChaCha20";
>>> 104:         }
>> 
>> Have you considered adding "ChaCha20-Poly1305" into the "keyTypes" instead? Then you don't need to add the if-block here.
>
> That would indeed be cleaner solution. I'll make this change. Thank you.

Please update the 2nd copyright year to 2022 also.

-------------

PR: https://git.openjdk.org/jdk/pull/9072



More information about the security-dev mailing list