RFR: JDK-8284851 Update javax.crypto files to use proper javadoc for mentioned classes [v2]

Valerie Peng valeriep at openjdk.org
Tue Jun 28 21:15:05 UTC 2022


On Tue, 28 Jun 2022 19:32:07 GMT, Mark Powers <duke at openjdk.org> wrote:

>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Valerie fix

src/java.base/share/classes/javax/crypto/CipherOutputStream.java line 126:

> 124:      * using a <code>NullCipher</code>.
> 125:      * <br>Note: if the specified output stream is <code>null</code>, a
> 126:      * NullPointerException may be thrown later when it is used.

Add {@code } to NullPointerException also.

src/java.base/share/classes/javax/crypto/CipherSpi.java line 227:

> 225: 
> 226:     /**
> 227:      * Sets the mode of this {@code Cipher}.

Same comment as in the one in Cipher.java, prefer to leave cipher alone.

src/java.base/share/classes/javax/crypto/CryptoAllPermission.java line 64:

> 62:      *
> 63:      * @return true if the specified permission is an
> 64:      * instance of <code>CryptoPermission</code>.

Use {@code } for all of the javadoc in this class?

src/java.base/share/classes/javax/crypto/CryptoPermission.java line 40:

> 38:  * The <code>CryptoPermission</code> class extends the
> 39:  * <code>java.security.Permission</code> class. A
> 40:  * <code>CryptoPermission</code> object is used to represent

Use {@code } for all of the javadoc in this class?

-------------

PR: https://git.openjdk.org/jdk/pull/9282



More information about the security-dev mailing list