RFR: JDK-8282686: Add constructors taking a cause to SocketException

Alan Bateman alanb at openjdk.java.net
Sat Mar 5 09:50:03 UTC 2022


On Fri, 4 Mar 2022 21:17:01 GMT, Joe Darcy <darcy at openjdk.org> wrote:

> Please review this small API enhancement to add the usual constructors taking a cause to SocketException and then update uses of initiCause on creating SocketException to instead pass the cause via the constructor.
> 
> Please also review the CSR: https://bugs.openjdk.java.net/browse/JDK-8282688

This looks good, I just wonder if we should add a test for the new constructors. One of them will be tested by the usages in the JDK, the cause-only constructor may not be exercised by any code.

-------------

Marked as reviewed by alanb (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7705



More information about the security-dev mailing list