RFR: 8282723: Add constructors taking a cause to JSSE exceptions [v2]

[Bradford Wetmore]

On Mon, 7 Mar 2022 19:42:47 GMT, Xue-Lei Andrew Fan <xuelei at openjdk.org> wrote:

>> Please review this small API enhancement to add the usual constructors taking a cause to javax.net.ssl exceptions.  The use of initCause in the JSSE implementation code is updated to use the new constructors accordingly.
>> 
>> Please review the CSR: https://bugs.openjdk.java.net/browse/JDK-8282724
>
> Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   typo correction

Didn't see any unit tests for the new methods.  Can approve after they are included.

src/java.base/share/classes/sun/security/ssl/ECDHKeyExchange.java line 204:

> 202:             } catch (GeneralSecurityException | java.io.IOException e) {
> 203:                 throw new SSLHandshakeException(
> 204:                         "Could not generate ECPublicKey", e);

Nit:  I think combining these lines would be < 80 chars

src/java.base/share/classes/sun/security/ssl/SSLSocketInputRecord.java line 263:

> 261:             fragment = plaintext.fragment;
> 262:             contentType = plaintext.contentType;
> 263:         } catch (BadPaddingException bpe) {

Does the copyright need to get updated?

-------------

PR: https://git.openjdk.java.net/jdk/pull/7722