RFR: 8282723: Add constructors taking a cause to JSSE exceptions [v5]

Bradford Wetmore wetmore at openjdk.java.net
Fri Mar 18 21:03:41 UTC 2022


On Tue, 8 Mar 2022 08:02:16 GMT, Xue-Lei Andrew Fan <xuelei at openjdk.org> wrote:

>> Please review this small API enhancement to add the usual constructors taking a cause to javax.net.ssl exceptions.  The use of initCause in the JSSE implementation code is updated to use the new constructors accordingly.
>> 
>> Please review the CSR: https://bugs.openjdk.java.net/browse/JDK-8282724
>
> Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   more test case udpate

test/jdk/javax/net/ssl/ALPN/SSLServerSocketAlpnTest.java line 487:

> 485:         if ((local != null) && (remote != null)) {
> 486:             // If both failed, return the curthread's exception.
> 487:             local.addSuppressed(remote);

Copyright 2016->2022.

test/jdk/javax/net/ssl/ALPN/SSLSocketAlpnTest.java line 483:

> 481:         if ((local != null) && (remote != null)) {
> 482:             // If both failed, return the curthread's exception.
> 483:             local.addSuppressed(remote);

Copyright 2016->2022.

test/jdk/javax/net/ssl/SSLException/CheckSSLHandshakeException.java line 2:

> 1: /*
> 2:  * Copyright (C) 2022 THL A29 Limited, a Tencent company. All rights reserved.

I am unsure about the copyrights on these files.  They are probably ok, but you should get approval by someone more familiar.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7722



More information about the security-dev mailing list